Refactor chat memory repository artifacts for clarity #3095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename the artifact ID of the chat memory repository artifacts:
- `spring-ai-model-chat-memory-jdbc` -> `spring-ai-model-chat-memory-repository-jdbc`
- `spring-ai-model-chat-memory-cassandra` -> `spring-ai-model-chat-memory-repository-cassandra`
- `spring-ai-model-chat-memory-neo4j` -> `spring-ai-model-chat-memory-repository-neo4j`
- Rename the package names to include "repository". Example: org.springframework.ai.chat.memory.repository.jdbc.JdbcChatMemoryRepository
- This package renaming also requires to change the default schema location for the jdbc repository to include "repository"
- Update the docs
- Update the artifact IDs in the parent POM, BOM, autoconfiguration and starters
- Update upgrade notes and docs to describe the changes
Signed-off-by: Ilayaperumal Gopinathan <[email protected]>
- Make sure to set the dialect via datasource Signed-off-by: Ilayaperumal Gopinathan <[email protected]>
Signed-off-by: Ilayaperumal Gopinathan <[email protected]>
ilayaperumalg
force-pushed
the
chat-memory-repository-refactoring
branch
from
50ccfd6 to
54832fe
Compare
|
merged in 2d517ee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the artifact ID of the chat memory repository artifacts:
spring-ai-model-chat-memory-jdbc->spring-ai-model-chat-memory-repository-jdbcspring-ai-model-chat-memory-cassandra->spring-ai-model-chat-memory-repository-cassandraspring-ai-model-chat-memory-neo4j->spring-ai-model-chat-memory-repository-neo4jRename the package names to include "repository". Example: org.springframework.ai.chat.memory.repository.jdbc.JdbcChatMemoryRepository
Update the artifact IDs in the parent POM, BOM, autoconfiguration and starters
Update upgrade notes and docs to describe the changes